[vlc-devel] [PATCH] qt: use local-path for ui header wrapper

[Marvin Scholz]

On 10 Mar 2020, at 10:14, Alexandre Janniaux wrote:

> Hi,
>
> AFAIK, we will remove .ui files in the end, as QML
> supersedes it, not add new ones.
>
> In addition, you'll also get header guard conflicts from the
> generated header files if you do that, which is probably
> worse than using the wrong file which will produce an error
> as the class being used won't exist.
>
> Other than that, this is what is done in the meson branch so
> maybe ePirat can provide context?
>

Hi, this is something not done explicitly by me but by the meson
integration for meson.
This mimics what qmake, Qt’s native build system, does. If you have
multiple ui files with the same name even in different locations
it will generate two identical targets, one overriding the other
and only process one of the two files and in most cases
fail miserably as soon as those are included and do not provide
the expected classes.

So I believe we never should have two UI files with the same name
and IMO it was not the best idea to split the UI files in different
folders and maybe should revert that change, which would make
this patch unnecessary.

> Regards,
> --
> Alexandre Janniaux
> Videolabs
>
> On Tue, Mar 10, 2020 at 09:43:14AM +0200, Rémi Denis-Courmont wrote:
>> Le tiistaina 10. maaliskuuta 2020, 0.05.08 EET Alexandre Janniaux a 
>> écrit :
>>> Those files could generated in implementation-specified location by
>>> build systems and we don't need a full path. With meson, it will be
>>> handled automatically and having a full path makes the file not 
>>> found.
>>
>> This strikes me as a bad idea, as you can no longer have the same 
>> file names in
>> different directories.
>>
>> --
>> 雷米‧德尼-库尔蒙
>> http://www.remlab.net/
>>
>>
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel