[vlc-devel] [PATCH] decoder: assert that out_pool is valid from buffer_new

[Francois Cartegnie]

Le 10/03/2020 à 10:16, Steve Lhomme a écrit :
> On 2020-03-10 10:03, Francois Cartegnie wrote:
>> Le 10/03/2020 à 08:58, Thomas Guillem a écrit :
>>> Once the format is configured, the out_pool need to stay valid during
>>> the life
>>> time of the module or until a new format is requested.
>>> ---
>>>   src/input/decoder.c | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/src/input/decoder.c b/src/input/decoder.c
>>> index 7dbc2b8f8d..be6c916342 100644
>>> --- a/src/input/decoder.c
>>> +++ b/src/input/decoder.c
>>> @@ -650,6 +650,7 @@ static picture_t *ModuleThread_NewVideoBuffer(
>>> decoder_t *p_dec )
>>>   {
>>>       struct decoder_owner *p_owner = dec_get_owner( p_dec );
>>>       assert( p_owner->p_vout );
>>> +    assert( p_owner->out_pool );
>>>         picture_t *pic = picture_pool_Wait( p_owner->out_pool );
>>>       if (pic)
>>>
>>
>>
>> Just makes things abort somewhere else...
> 
> That's seems unrelated to this patch.

It is.
Now worse than before, can't change decoder at all.


-- 
Francois Cartegnie
VideoLAN - VLC Developer