[vlc-devel] [PATCH] Add module to submit listens to ListenBrainz.

[Rémi Denis-Courmont]

Le tiistaina 10. maaliskuuta 2020, 18.32.05 EET Kartik Ohri a écrit :
> On Tue, Mar 10, 2020 at 9:55 PM Rémi Denis-Courmont <remi at remlab.net> wrote:
> > Le sunnuntaina 8. maaliskuuta 2020, 19.14.41 EET Kartik Ohri a écrit :
> > > +    i_ret = vlc_tls_Read (sock, p_buffer, sizeof (p_buffer) - 1,
> > > false);
> > > +    msg_Dbg (p_this, "Response: %s", (char *) p_buffer);
> > > +    vlc_tls_Close (sock);
> > > +    if ( i_ret <= 0 )
> > > +    {
> > > +        msg_Warn (p_this, "No response");
> > > +        return 1;
> > > +    }
> > > +    p_buffer[i_ret] = '\0';
> > > +    if ( strstr ((char *) p_buffer, "OK") )
> > 
> > This is very sloppy coding.
> 
> I do not have much experience on working on writing something ground up or
> without guidance in a real world project. Can you point out the issue ? I
> will fix that in the next patch.

See RFC7230 and RFC7231.


-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/