[vlc-devel] [PATCH] es_out: use sout control only when sout is enabled

Mehdi Sabwat mehdisabwat at gmail.com
Wed Mar 11 09:20:00 CET 2020


On Tue, Mar 10, 2020, 20:55 Alexandre Janniaux <ajanni at videolabs.io> wrote:

> Is it relevant for size-sensitive platforms like the wasm
> port ?
>
Yes, I think. It is disabled for now.

As you said, using sout control when sout is disabled will break the build.
So the patch is needed.


> Regards,
> --
> Alexandre Janniaux
> Videolabs
>
> On Tue, Mar 10, 2020 at 06:55:01PM +0100, Jean-Baptiste Kempf wrote:
> > Yo,
> >
> > On Tue, Mar 10, 2020, at 17:27, Rémi Denis-Courmont wrote:
> > > Le tiistaina 10. maaliskuuta 2020, 8.51.51 EET Thomas Guillem a écrit :
> > > > It raises a question:
> > > > Should we remove ENABLE_SOUT defines in core ? I don't think we gain
> a lot
> > > > of binary size with this optim. The most important is to disable sout
> > > > modules compilation.
> > >
> > > What are the code size savings?
> >
> > I guess < 50kB on the 2MB libvlccore.
> >
> > However, it is significant on modules.
> >
> > --
> > Jean-Baptiste Kempf -  President
> > +33 672 704 734
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200311/bf4456ff/attachment.html>


More information about the vlc-devel mailing list