[vlc-devel] [PATCH 03/14] configure: remove unneeded config.h defines

[Marvin Scholz]

On 11 Mar 2020, at 14:33, Steve Lhomme wrote:

> Some explanation of why they are unneeded, for windows builds ?
>

I am clueless why most of these are there, I basically searched the
mingw-w64 sources to see if they are used in any relevant cases and
it seemed not / redundant with _POSIX_C_SOURCE.

If anyone knows a reason why all those are there in the first place,
please let me know.

> On 2020-03-11 13:37, Marvin Scholz wrote:
>> ---
>>   configure.ac | 7 -------
>>   1 file changed, 7 deletions(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index d10d30a3a2..c50e023725 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -248,14 +248,7 @@ case "${host_os}" in
>>       ])
>>       AC_DEFINE([_WIN32_IE], 0x0600, [Define to '0x0600' for IE 6.0 
>> (and shell) APIs.])
>>       AC_DEFINE([UNICODE], [1], [Define to 1 for Unicode (Wide Chars) 
>> APIs.])
>> -    AC_DEFINE([_ISOC99_SOURCE], [1], [Extensions to ISO C89 from ISO 
>> C99.])
>> -    AC_DEFINE([_ISOC11_SOURCE], [1], [Extensions to ISO C99 from ISO 
>> C11.])
>> -    AC_DEFINE([_POSIX_SOURCE], [1], [IEEE Std 1003.1.])
>>       AC_DEFINE([_POSIX_C_SOURCE], [200809L], [IEEE Std 1003.1.])
>> -    AC_DEFINE([_XOPEN_SOURCE], [700], [POSIX and XPG 7th edition])
>> -    AC_DEFINE([_XOPEN_SOURCE_EXTENDED], [1], [XPG things and X/Open 
>> Unix extensions.])
>> -    AC_DEFINE([_BSD_SOURCE], [1], [ISO C, POSIX, and 4.3BSD 
>> things.])
>> -    AC_DEFINE([_SVID_SOURCE], [1], [ISO C, POSIX, and SVID things.])
>>        case "${host_os}" in
>>         *mingw32*)
>> -- 
>> 2.21.1 (Apple Git-122.3)
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel