[vlc-devel] [PATCH 09/14] configure: darwin: add -D_INTL_REDIRECT_MACROS to CPPFLAGS

[Steve Lhomme]

On 2020-03-11 15:31, Marvin Scholz wrote:
> On 11 Mar 2020, at 14:36, Steve Lhomme wrote:
> 
>> It seems the patch is doing more than that. Like adding -std=gnu11 for 
>> this mac target.
>>
> 
> Hmm I don’t see that, maybe you misread the diff or I overlooked something?
> 
> -    CFLAGS="${CFLAGS} -D_INTL_REDIRECT_MACROS -std=gnu11"
> +    CFLAGS="${CFLAGS} -std=gnu11"
> 
> This does not add -std=gnu11, it was there before and is there after.

Ah yes, it was one line above.

> Maybe my commit message was a bit unclear, I remove the 
> _INTL_REDIRECT_MACROS define
> from other flags and add it to CPPFLAGS, in the end it will make no 
> difference as
> CPPFLAGS are used in all those cases too.
> 
>> On 2020-03-11 13:37, Marvin Scholz wrote:
>>> ---
>>>   configure.ac | 7 +++----
>>>   1 file changed, 3 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/configure.ac b/configure.ac
>>> index 12e16e3641..c6b51f88d9 100644
>>> --- a/configure.ac
>>> +++ b/configure.ac
>>> @@ -169,11 +169,10 @@ case "${host_os}" in
>>>         ;;
>>>       esac
>>>  -    CFLAGS="${CFLAGS} -D_INTL_REDIRECT_MACROS -std=gnu11"
>>> +    AX_APPEND_FLAG([-D_INTL_REDIRECT_MACROS], [CPPFLAGS])
>>> +    CFLAGS="${CFLAGS} -std=gnu11"
>>>       CXX="${CXX} -stdlib=libc++ -std=c++11"
>>> -    CXXFLAGS="${CXXFLAGS} -D_INTL_REDIRECT_MACROS"
>>> -    CPPFLAGS="${CPPFLAGS}"
>>> -    OBJCFLAGS="${OBJCFLAGS} -D_INTL_REDIRECT_MACROS -std=gnu11 
>>> -Werror=partial-availability"
>>> +    OBJCFLAGS="${OBJCFLAGS} -std=gnu11 -Werror=partial-availability"
>>>       LDFLAGS="${LDFLAGS} -Wl,-headerpad_max_install_names"
>>>       VLC_ADD_LIBS([libvlc 
>>> vlc],[-Wl,-undefined,dynamic_lookup,-framework,AppKit])
>>>       
>>> VLC_ADD_LIBS([libvlccore],[-Wl,-framework,CoreFoundation,-framework,CoreServices]) 
>>>
>>> -- 
>>> 2.21.1 (Apple Git-122.3)
>>>
>>> _______________________________________________
>>> vlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
>>> https://mailman.videolan.org/listinfo/vlc-devel
>>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel