[vlc-devel] [PATCH 02/14] configure: add unknown args error flag to OBJCFLAGS too

[Marvin Scholz]

On 11 Mar 2020, at 16:25, Steve Lhomme wrote:

> On 2020-03-11 15:19, Marvin Scholz wrote:
>>
>>
>> On 11 Mar 2020, at 14:30, Steve Lhomme wrote:
>>
>>> 2020-03-11 13:37, Marvin Scholz wrote:
>>>> ---
>>>>   configure.ac | 2 ++
>>>>   1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/configure.ac b/configure.ac
>>>> index ca3f3e1a93..d10d30a3a2 100644
>>>> --- a/configure.ac
>>>> +++ b/configure.ac
>>>> @@ -87,10 +87,12 @@ dnl Prevent clang from accepting unknown flags 
>>>> with a mere warning
>>>>   AX_CHECK_COMPILE_FLAG([-Werror=invalid-command-line-argument], [
>>>>     AX_APPEND_FLAG([-Werror=invalid-command-line-argument], 
>>>> [CFLAGS])
>>>>     AX_APPEND_FLAG([-Werror=invalid-command-line-argument], 
>>>> [CXXFLAGS])
>>>> +  AX_APPEND_FLAG([-Werror=invalid-command-line-argument], 
>>>> [OBJCFLAGS])
>>>
>>> Wrong copy paste ?
>>
>> I don’t see anything wrong here?
>
> Indeed, I thought you should be adding the same option in 2 places. 
> But it seems you're adding the same flags from C/C++ to Obj-C. IMO the 
> title is misleading.
>

Hm not sure whats confusing about it but if you have a suggestions how 
to reword I’ll
happily do it.

>>>
>>>>   ])
>>>>   AX_CHECK_COMPILE_FLAG([-Werror=unknown-warning-option], [
>>>>     AX_APPEND_FLAG([-Werror=unknown-warning-option], [CFLAGS])
>>>>     AX_APPEND_FLAG([-Werror=unknown-warning-option], [CXXFLAGS])
>>>> +  AX_APPEND_FLAG([-Werror=unknown-warning-option], [OBJCFLAGS])
>>>>   ])
>>>>    dnl
>>>> -- 
>>>> 2.21.1 (Apple Git-122.3)
>>>>
>>>> _______________________________________________
>>>> vlc-devel mailing list
>>>> To unsubscribe or modify your subscription options:
>>>> https://mailman.videolan.org/listinfo/vlc-devel
>>>>
>>> _______________________________________________
>>> vlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
>>> https://mailman.videolan.org/listinfo/vlc-devel
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel