[vlc-devel] [vlc-commits] playlist: m3u: use cctype

Remi Denis-Courmont remi at remlab.net
Thu Mar 12 18:26:07 CET 2020

Le 2020-03-12 19:10, Francois Cartegnie a écrit :
> Le 12/03/2020 à 17:24, Remi Denis-Courmont a écrit :
>>> I don't see why that would still be undefined with utf8 if we use _l
>>> locale C ones.
>> I fail to see the relevance of UTF-8 here.
>>> Even if, UB for a bool would break parsing as much as broken 
>>> separators.
>> If you're not going to revert the patch, I can do that myself, but 
>> that
>> will involve reverting any intermediate patch.
> You did not answer regarding the C locale ones.

What do you want with them? It wouldn't change anything w.r.t. UB, even 
if you could use them to force the C locale. And it's going to much 
slower and more complicated than the previous code, or strspn().

> And If I read correctly, scanf using any space in format string should
> be also replaced by a custom impl..

So what if there are iffy locale-dependent usages of sscanf() in a few 
other places? Bad code elsewhere is not an excuse for making bad code, 

Rémi Denis-Courmont

More information about the vlc-devel mailing list