[vlc-devel] [PATCH 08/14] configure: darwin: do not explicitly set ARCH_flag

[Alexandre Janniaux]

Hi,

Can you explain in the commit message where it is expected
to pass the flag instead or why it should not be passed here
if more relevant?

Regards,
--
Alexandre Janniaux
Videolabs

On Wed, Mar 11, 2020 at 01:37:29PM +0100, Marvin Scholz wrote:
> ---
>  configure.ac | 14 +++++---------
>  1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 9a16ec020a..12e16e3641 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -154,16 +154,12 @@ case "${host_os}" in
>      CXXFLAGS="${CXXFLAGS} -fno-stack-check"
>      OBJCFLAGS="${OBJCFLAGS} -fno-stack-check"
>
> -    dnl Force gcc "-arch" flag
> -    ARCH_flag=""
>      case "${host_cpu}" in
>        i?86)
> -        ARCH_flag="-arch i386"
>          X86ASMFLAGS="-f macho32"
>          AX_APPEND_FLAG([-DPREFIX], [X86ASMDEFS])
>        ;;
>        x86_64)
> -        ARCH_flag="-arch x86_64"
>          X86ASMFLAGS="-f macho64"
>          AX_APPEND_FLAG([-DPREFIX], [X86ASMDEFS])
>        ;;
> @@ -173,12 +169,12 @@ case "${host_os}" in
>        ;;
>      esac
>
> -    CFLAGS="${CFLAGS} -D_INTL_REDIRECT_MACROS -std=gnu11 ${ARCH_flag}"
> +    CFLAGS="${CFLAGS} -D_INTL_REDIRECT_MACROS -std=gnu11"
>      CXX="${CXX} -stdlib=libc++ -std=c++11"
> -    CXXFLAGS="${CXXFLAGS} -D_INTL_REDIRECT_MACROS ${ARCH_flag}"
> -    CPPFLAGS="${CPPFLAGS} ${ARCH_flag}"
> -    OBJCFLAGS="${OBJCFLAGS} -D_INTL_REDIRECT_MACROS -std=gnu11 ${ARCH_flag} -Werror=partial-availability"
> -    LDFLAGS="${LDFLAGS} -Wl,-headerpad_max_install_names ${ARCH_flag}"
> +    CXXFLAGS="${CXXFLAGS} -D_INTL_REDIRECT_MACROS"
> +    CPPFLAGS="${CPPFLAGS}"
> +    OBJCFLAGS="${OBJCFLAGS} -D_INTL_REDIRECT_MACROS -std=gnu11 -Werror=partial-availability"
> +    LDFLAGS="${LDFLAGS} -Wl,-headerpad_max_install_names"
>      VLC_ADD_LIBS([libvlc vlc],[-Wl,-undefined,dynamic_lookup,-framework,AppKit])
>      VLC_ADD_LIBS([libvlccore],[-Wl,-framework,CoreFoundation,-framework,CoreServices])
>
> --
> 2.21.1 (Apple Git-122.3)
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel