[vlc-devel] [PATCH 01/14] configure: restructure adding unknown args error flags

Marvin Scholz epirat07 at gmail.com
Fri Mar 13 11:10:12 CET 2020



On 13 Mar 2020, at 10:53, Alexandre Janniaux wrote:

> Hi,
>
> Maybe you can explain by quoting the previous output and
> resulting output in the long commit message. It would make
> both the commit and the configure output clearer.
>
> We generally compile with the same flavour of C and C++
> compiler but just to be sure won't it raise issues if the
> flavour is different? Was it a pre-existing issue? It's not
> a blocking point for me at all, but just to make it clear
> for me.
>

In theory if for whatever reason you use Clang as C compiler
and GCC as C++ compiler, this would fail, yes.

This is how it already was before this patch.

> Regards,
> --
> Alexandre Janniaux
> Videolabs
>
> On Wed, Mar 11, 2020 at 03:18:42PM +0100, Marvin Scholz wrote:
>> On 11 Mar 2020, at 14:30, Steve Lhomme wrote:
>>
>>> Restructure ?
>>>
>>> AFAIK AX_APPEND_COMPILE_FLAGS() does what you replaced it with, with
>>> less lines.
>>
>> Thats why I said „restructure“, it does not affect the outcome.
>>
>> This makes it much clearer that only the C compiler is tested for this
>> flag and is less confusing in the configure output.
>>
>>>
>>>
>>> On 2020-03-11 13:37, Marvin Scholz wrote:
>>>> ---
>>>>   configure.ac | 10 ++++++++--
>>>>   1 file changed, 8 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/configure.ac b/configure.ac
>>>> index bc1874cb97..ca3f3e1a93 100644
>>>> --- a/configure.ac
>>>> +++ b/configure.ac
>>>> @@ -84,8 +84,14 @@ AS_IF([test -n "${with_binary_version}"],[
>>>>   ])
>>>>    dnl Prevent clang from accepting unknown flags with a mere warning
>>>> -AX_APPEND_COMPILE_FLAGS([-Werror=unknown-warning-option
>>>> -Werror=invalid-command-line-argument], [CFLAGS])
>>>> -AX_APPEND_COMPILE_FLAGS([-Werror=unknown-warning-option
>>>> -Werror=invalid-command-line-argument], [CXXFLAGS])
>>>> +AX_CHECK_COMPILE_FLAG([-Werror=invalid-command-line-argument], [
>>>> +  AX_APPEND_FLAG([-Werror=invalid-command-line-argument], [CFLAGS])
>>>> +  AX_APPEND_FLAG([-Werror=invalid-command-line-argument],
>>>> [CXXFLAGS])
>>>> +])
>>>> +AX_CHECK_COMPILE_FLAG([-Werror=unknown-warning-option], [
>>>> +  AX_APPEND_FLAG([-Werror=unknown-warning-option], [CFLAGS])
>>>> +  AX_APPEND_FLAG([-Werror=unknown-warning-option], [CXXFLAGS])
>>>> +])
>>>>    dnl
>>>>   dnl  Check the operating system
>>>> --
>>>> 2.21.1 (Apple Git-122.3)
>>>>
>>>> _______________________________________________
>>>> vlc-devel mailing list
>>>> To unsubscribe or modify your subscription options:
>>>> https://mailman.videolan.org/listinfo/vlc-devel
>>>>
>>> _______________________________________________
>>> vlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
>>> https://mailman.videolan.org/listinfo/vlc-devel
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list