[vlc-devel] [PATCH] es_out: use sout control only when sout is enabled

[Rémi Denis-Courmont]

Le perjantaina 13. maaliskuuta 2020, 12.25.59 EET Alexandre Janniaux a écrit :
> Hi,
> 
> Ping,
> 
> I believe that if we can reduce libvlccore size, even
> slightly, the WASM platform would benefit a lot as it would
> reduce page loads. Keeping the ENABLE_SOUT in the core seems
> a good idea regarding that.

I'm not really buying that argument. There are plenty of ways that code size 
could be shrunk, and SOUT is not the biggest (nor VLM). For one thing, a *lot* 
of code all over the place can only be triggered with VLC interfaces, and 
won't work inside any other LibVLC-based app.

Not to even speak of code inside contribs, which dwarves the core and even the 
(non-GUI) plugins.

The only reason for the ifdef's exist is that we a conditional for plugins 
anyway, so why not use it for the core too. The main argument against is that 
src/missing.c has caused a lot of stupid accidental build failures in the 
past, and will continue to do so as long as it is allowed to exist.

-- 
レミ・デニ-クールモン
http://www.remlab.net/