[vlc-devel] [PATCH] es_out: use sout control only when sout is enabled

Rémi Denis-Courmont remi at remlab.net
Fri Mar 13 13:37:58 CET 2020


Le perjantaina 13. maaliskuuta 2020, 14.05.02 EET Alexandre Janniaux a écrit :
> Hi,
> 
> The goal for the WASM platform is to avoid downloading
> plugins that are heavy and only use those that can be
> baked by platform features.

Leaving aside the UIs, the larger plugins are the indispensable ones 
(libavcodec, gcrypt, etc) so I fail to get where you're going with that.

Also just check for yourself by putting a breakpoint on dlopen() how many 
plugins VLC loads for a simple playback, that it does not even use in the end 
(because probing fails). Notably demuxers, packetizers and decoders.

> Achieving that can be done only after libvlccore has been
> downloaded, so libvlccore size immediately impact latency
> and I don't think there is a huge trivial gain regarding
> this. All opportunity to reduce useless code size is probably
> welcome for the final user.

Not really no. If it's negligible it's negligible.

This feature has a real maintenance cost for no known *noticeable* benefits. 
Just like removing UI-only code in the core would have high maintenance cost 
for all in all little gains. There are far more efficient, more systematic and 
less error-prone ways to eliminate some of the dead code.

-- 
Rémi Denis-Courmont
http://www.remlab.net/





More information about the vlc-devel mailing list