[vlc-devel] [PATCH 2/5] qt: variables: don't create variables we already read from

Steve Lhomme robux4 at ycbcr.xyz
Fri Mar 13 15:00:29 CET 2020


A few lines above we already use the variable:
var_Get(m_object->get(), qtu(m_property), &currentvalue)
---
 modules/gui/qt/util/variables.hpp | 2 --
 1 file changed, 2 deletions(-)

diff --git a/modules/gui/qt/util/variables.hpp b/modules/gui/qt/util/variables.hpp
index dff7e84bcb2..08f1de8ef07 100644
--- a/modules/gui/qt/util/variables.hpp
+++ b/modules/gui/qt/util/variables.hpp
@@ -154,7 +154,6 @@ public:
                 emit derived->valueChanged( m_value );
             }
 
-            var_Create(m_object->get(), qtu(m_property), VLCVarTypeTraits<BaseType>::var_type);
             var_AddCallback(m_object->get(), qtu(m_property), value_modified, &cref);
         }
     }
@@ -164,7 +163,6 @@ public:
         if (m_object->get())
         {
             var_DelCallback( m_object->get(), qtu(m_property), value_modified, &cref );
-            var_Destroy(m_object->get(), qtu(m_property));
             m_object->clear();
         }
     }
-- 
2.17.1



More information about the vlc-devel mailing list