[vlc-devel] [PATCH v4 5/7] libvlc: don't force "dec-dev" with libvlc_media_player_set_xwindow()

Steve Lhomme robux4 at ycbcr.xyz
Mon Mar 16 09:48:13 CET 2020


On 2020-03-13 16:46, Rémi Denis-Courmont wrote:
> Le perjantaina 13. maaliskuuta 2020, 14.28.36 EET Steve Lhomme a écrit :
>> It should use the default value or the one set with
>> libvlc_video_set_hw_acceleration().
> 
> "" *is* the default value.

If that's the case the current code would be a no-op. But it's not. If 
you set the --dec-dev in the libvlc command-line, using set_xwindow() 
resets that value, for no particular reason.

> This patch is doing the opposite of what it says.
> 
>> ---
>>   lib/media_player.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/lib/media_player.c b/lib/media_player.c
>> index 024f765b9bd..89669c115b7 100644
>> --- a/lib/media_player.c
>> +++ b/lib/media_player.c
>> @@ -1144,7 +1144,6 @@ void libvlc_media_player_set_xwindow(
>> libvlc_media_player_t *p_mi, {
>>       assert (p_mi != NULL);
>>
>> -    var_SetString (p_mi, "dec-dev", "");
>>       var_SetString (p_mi, "vout", "");
>>       var_SetString (p_mi, "window", drawable ? "embed-xid,any" : "");
>>       var_SetInteger (p_mi, "drawable-xid", drawable);
> 
> 
> -- 
> 雷米‧德尼-库尔蒙
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> 


More information about the vlc-devel mailing list