[vlc-devel] [PATCH v4 5/7] libvlc: don't force "dec-dev" with libvlc_media_player_set_xwindow()

[Steve Lhomme]

On 2020-03-16 11:01, Rémi Denis-Courmont wrote:
> Le maanantaina 16. maaliskuuta 2020, 10.48.13 EET Steve Lhomme a écrit :
>> On 2020-03-13 16:46, Rémi Denis-Courmont wrote:
>>> Le perjantaina 13. maaliskuuta 2020, 14.28.36 EET Steve Lhomme a écrit :
>>>> It should use the default value or the one set with
>>>> libvlc_video_set_hw_acceleration().
>>>
>>> "" *is* the default value.
>>
>> If that's the case the current code would be a no-op. But it's not. If
>> you set the --dec-dev in the libvlc command-line, using set_xwindow()
>> resets that value, for no particular reason.
> 
> Actually, it resets that value for very particular reasons - re-enabling the
> X11 accelerations that vmem disabled.

It should be removed as well. There's no reason why it would benefit 
from hardware decoding. It's still possible to disable it with the 
proposed API in this patchset.

> Also FWIW, the official default is "any" not "".
> 
> -- 
> Реми Дёни-Курмон
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>