[vlc-devel] [PATCH v4 5/7] libvlc: don't force "dec-dev" with libvlc_media_player_set_xwindow()

[Rémi Denis-Courmont]

Le tiistaina 17. maaliskuuta 2020, 8.56.44 EET Steve Lhomme a écrit :
> On 2020-03-16 17:40, Rémi Denis-Courmont wrote:
> > Le maanantaina 16. maaliskuuta 2020, 12.14.22 EET Steve Lhomme a écrit :
> >> On 2020-03-16 11:01, Rémi Denis-Courmont wrote:
> >>> Le maanantaina 16. maaliskuuta 2020, 10.48.13 EET Steve Lhomme a écrit :
> >>>> On 2020-03-13 16:46, Rémi Denis-Courmont wrote:
> >>>>> Le perjantaina 13. maaliskuuta 2020, 14.28.36 EET Steve Lhomme a écrit 
:
> >>>>>> It should use the default value or the one set with
> >>>>>> libvlc_video_set_hw_acceleration().
> >>>>> 
> >>>>> "" *is* the default value.
> >>>> 
> >>>> If that's the case the current code would be a no-op. But it's not. If
> >>>> you set the --dec-dev in the libvlc command-line, using set_xwindow()
> >>>> resets that value, for no particular reason.
> >>> 
> >>> Actually, it resets that value for very particular reasons - re-enabling
> >>> the X11 accelerations that vmem disabled.
> >> 
> >> It should be removed as well.
> > 
> > No.
> 
> Even if not removed, for technical reasons yet to determine, it can use
> the set_hw_acceleration() API instead of this call.

No. There are zero reasons why the application developpers should have to care 
about this implementation detail of LibVLC.

And even setting the decoder device explicitly depending on the video window 
embedded regime becomes no longer "necessary" for correct functionality, it 
remains highly desirable for performance reasons.

Loading VLC plugins is not free, especially those involving display drivers.

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/