[vlc-devel] [PATCH] video_output: remove wrong assertion

Steve Lhomme robux4 at ycbcr.xyz
Tue Mar 17 10:21:33 CET 2020


LGTM

On 2020-03-17 10:15, Alexandre Janniaux wrote:
> If the display fails to open and a libvlc application request the media
> player to pause, it will assert although you don't need a display to
> pause the video output.
> ---
>   src/video_output/video_output.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/src/video_output/video_output.c b/src/video_output/video_output.c
> index a711d302af..357936f5db 100644
> --- a/src/video_output/video_output.c
> +++ b/src/video_output/video_output.c
> @@ -1359,7 +1359,6 @@ static int ThreadDisplayPicture(vout_thread_t *vout, vlc_tick_t *deadline)
>   void vout_ChangePause(vout_thread_t *vout, bool is_paused, vlc_tick_t date)
>   {
>       assert(!vout->p->dummy);
> -    assert(vout->p->display);
>   
>       vout_control_Hold(&vout->p->control);
>       assert(!vout->p->pause.is_on || !is_paused);
> -- 
> 2.25.1
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> 


More information about the vlc-devel mailing list