[vlc-devel] [PATCH] win32: build.sh: trigger build errors on dubious pointer use

[Steve Lhomme]

On 2020-03-17 12:21, Rémi Denis-Courmont wrote:
> Le tiistaina 17. maaliskuuta 2020, 13.02.02 EET Steve Lhomme a écrit :
>> On 2019-10-03 14:06, Rémi Denis-Courmont wrote:
>>> This is as bad, if not worse, in the win32 script that in the common
>>> configure.
>>>
>>> Besides, Windows has in-built incorrect pointer types, so that's making
>>> sure it won't work. E.g. haphazardly using char or uchar instead of void
>>> for binary I/O functions.
>>
>> I'm not sure what you're referring to but either we don't use any of
>> these or the casts are already done properly since the code compiles
>> with these checks on.
> 
> There are a lot of invalid casts in the Windows code: Almost every COM
> instantiation in the VLC code base is an aliasing violation (though that's
> orthogonal to this patch).
> 
> But again, I'm referring to binary I/O functions here.

Then I don't know what you're talking about.