[vlc-devel] [PATCH v2] package/win32: build.sh: trigger build errors on dubious pointer use

[Steve Lhomme]

On 2020-03-18 11:47, Rémi Denis-Courmont wrote:
> Le keskiviikkona 18. maaliskuuta 2020, 10.57.13 EET Steve Lhomme a écrit :
>> You're still talking about a different type of pointer issues that can
>> be solved with casting. (and that will be silenced anyway since we tend
>> to do commits to suppress warnings)
> 
> I am talking about an issue that is wrongly silenced by casting and stems from
> the same named warning category. Call that a different proble if you will, it's
> still the same category.
> > Treating warnings as errors is bad both because it breaks the build 
needlessly
> for harmless or minor issues, and because it increases the incentive to mute
> warnings instead of fixing actual bugs.

It's not a hard rule or any warning we turn as errors. It's the most 
critical ones that may cause serious issues if unattended.

We already turn on errors for:
-Werror=unknown-warning-option
-Werror=invalid-command-line-argument
-Werror-implicit-function-declaration

They seem less critical to me than mismatching pointers.