[vlc-devel] [PATCH 02/16] opengl: use OpenGL ES 2 on Android

[Romain Vimont]

On 3/18/20 8:21 AM, Steve Lhomme wrote:
> What module needs this ? The Android Interop module is compiled with 
> -DUSE_OPENGL_ES2

For now, none. It's for filters on my local branch.

> IMO that's more something that could be tunes with configure in the 
> future and enabled "globally" for antyhing that uses OpenGL on the 
> platform. It should be added to OPENGL_COMMONCFLAGS (same thing for 
> iOS/tvOS).

OK (Alex also said this).

So I remove this patch from this patchset. I move it up in my local 
branch, and will try to do it from Makefile.am instead.

> On 2020-03-17 17:26, Romain Vimont wrote:
>> ---
>>   modules/video_output/opengl/gl_common.h | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/modules/video_output/opengl/gl_common.h 
>> b/modules/video_output/opengl/gl_common.h
>> index 26ff00d7cc..842c08b780 100644
>> --- a/modules/video_output/opengl/gl_common.h
>> +++ b/modules/video_output/opengl/gl_common.h
>> @@ -38,6 +38,10 @@
>>   #  include <OpenGLES/ES2/glext.h>
>>   # endif
>>   #else /* !defined (__APPLE__) */
>> +# if defined(__ANDROID__) && !defined(USE_OPENGL_ES2)
>> +/* Force OpenGL ES 2 on Android */
>> +#  define USE_OPENGL_ES2
>> +# endif
>>   # if defined (USE_OPENGL_ES2)
>>   #  include <GLES2/gl2.h>
>>   #  include <GLES2/gl2ext.h>
>> -- 
>> 2.25.1
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel