[vlc-devel] [3.x 2/2] macosx vouts: Adjust module priorities

David Fuhrmann david.fuhrmann at gmail.com
Sat Mar 21 20:46:59 CET 2020


Hi Marvin,

Just noticed this is not merged yet, both patches look good to me.

Once its merged, we could also ask some users in the forum to test the latest nightly, to get some more feedback on this switch.

BTW, I assume you already plan to forward-port all those changes to the vlc.git as well?

BR. David

> Am 02.03.2020 um 12:26 schrieb Marvin Scholz <epirat07 at gmail.com>:
> 
> This and the previous commit ensure that the new CAOpenGLLayer based
> video output is used on macOS 10.14 and higher if the output selection
> is set to automatic.
> ---
> modules/video_output/caopengllayer.m | 2 +-
> modules/video_output/macosx.m        | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/modules/video_output/caopengllayer.m b/modules/video_output/caopengllayer.m
> index de363bd3a4..739a3dcb10 100644
> --- a/modules/video_output/caopengllayer.m
> +++ b/modules/video_output/caopengllayer.m
> @@ -934,7 +934,7 @@ - (CGLContextObj)copyCGLContextForPixelFormat:(CGLPixelFormatObj)pixelFormat
> 
> vlc_module_begin()
>     set_description(N_("Core Animation OpenGL Layer (Mac OS X)"))
> -    set_capability("vout display", 0)
> +    set_capability("vout display", 300)
>     set_category(CAT_VIDEO)
>     set_subcategory(SUBCAT_VIDEO_VOUT)
>     set_callbacks(Open, Close)
> diff --git a/modules/video_output/macosx.m b/modules/video_output/macosx.m
> index df2f3030bb..da9c955f85 100644
> --- a/modules/video_output/macosx.m
> +++ b/modules/video_output/macosx.m
> @@ -75,7 +75,7 @@
>     set_description (N_("Mac OS X OpenGL video output"))
>     set_category (CAT_VIDEO)
>     set_subcategory (SUBCAT_VIDEO_VOUT)
> -    set_capability ("vout display", 300)
> +    set_capability ("vout display", 250)
>     set_callbacks (Open, Close)
>     add_shortcut ("macosx", "vout_macosx")
>     add_glopts ()
> -- 
> 2.21.1 (Apple Git-122.3)
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel



More information about the vlc-devel mailing list