[vlc-devel] [PATCH 1/3] contrib: add a way to build native tools from contribs

[Steve Lhomme]

On 2020-03-23 13:06, Rémi Denis-Courmont wrote:
> Le maanantaina 23. maaliskuuta 2020, 13.41.07 EET Steve Lhomme a écrit :
>> Add a tool to be built natively in PKGS_PROGS.
> 
> This is way too simplistic to work. Basically, it works once, and then it
> fails when somebody updates contribs.

I fail to see how it changes this behavior. If the contrib changes and 
you build contribs normally, the depedency kicks in and the new program 
depends on the new .tar file.

This is the same when you call "make native-programs". For example with 
luac it native-programs depends on .luac which will depend on a new .tar 
file that needs to be downloaded and built.

>> Native tools are built automatically when using "make prebuilt" when cross
>> compiling as they are not part of the prebuilt package and needed for the
>> local platform.
> 
> That's missing the point. Prebuilt is lying about what it is, including build
> tools without any indication of the build triplet.
> 
> On one hand, we cannot split prebuilt orthogonally between build and host
> parts, as some build artefacts depend on both the host and the build triplet.
> On the other hand, simply building the tools after downloading prebuilt is at
> beast imprudent, as there may be nontrivial interdependencies. For instance,
> lua and luac packages must be patched in sync.

That means lua should be built alongside luac. It defeats the purpose a 
little but why not. If we do the same with protoc that's a lot to build 
when in fact you just wanted to use prebuilt as much as possible.

The problem exist right now anyway, if one updates lua or protobuf, 
prebuilt will not be useful until the next day. This patch doesn't 
change that.

> Prebuilt naming should be fixed to include both triplets, is all.

Both triplets are already set during bootstrap (which should be called 
"configure"). No need to duplicate these values in the target name.