[vlc-devel] [PATCH v2 3/3] fingerprinter: use vlc_cond_t instead of sleep

[Rémi Denis-Courmont]

Le maanantaina 23. maaliskuuta 2020, 20.07.49 EET Alexandre Janniaux a écrit :
> I fixed the issues mentioned by Rémi and added information
> about the previous state of the file.

Yes. No objections from me, but better check with the original author, prolly.
 
> I didn't send the thread cancellation -> boolean patch though
> because it was not very simplifying anything (+16 -11) and it
> needed an additional atomic as the lock is not shared between
> the incoming queue steal at the beginning and the processing
> queue later.

> I'll send it in a separate patchset afterwards to have more
> opinion on it, but I don't think mine is for removal of this
> thread cancellation code.

I don't care either way. Your patch does add one use of the, err, unwieldly 
and unloved, cleanup handlers. Then again, multiple wait points is one of the 
scenarii where thread cancellation shines over ad-hoc exit handling.

-- 
Rémi Denis-Courmont
http://www.remlab.net/