[vlc-devel] [PATCH 2/2] rand: only load the random generator algorithm once

[Steve Lhomme]

On 2020-03-27 8:41, Rémi Denis-Courmont wrote:
> Le perjantaina 27. maaliskuuta 2020, 9.34.25 EET Steve Lhomme a écrit :
>> On 2020-03-26 17:20, Rémi Denis-Courmont wrote:
>>> Le torstaina 26. maaliskuuta 2020, 17.33.37 EET Steve Lhomme a écrit :
>>>> According to the documentation:
>>>> Because of the number and type of operations that are required to find,
>>>> load, and initialize an algorithm provider, the
>>>> BCryptOpenAlgorithmProvider
>>>> function is a relatively time intensive function. Because of this, we
>>>> recommend that you cache any algorithm provider handles that you will use
>>>> more than once, rather than opening and closing the algorithm providers
>>>> over and over.
>>>>
>>>> We don't release it anymore but it should be released when the process
>>>> ends.>
>>> So what happens if LibVLC is loaded/unloaded multiple times in the same
>>> process?
>>
>> The same as the other vlc_once() calls in the core.
> 
> vlc_CPU_init() does not leak any resources.
> 
>> Anyway I don't think it's good to load/unload libvlc multiple times in
>> the same process, since we don't unload the DLLs it loads.
> 
> Where? LibVLC unloads plugins before exit.
> 
> If something leaks, it's a bug.

Then we could have a call in the core when exiting to release pending 
resources. (or maybe it already exists)