[vlc-devel] [PATCH] opensles_android: fix integer print format

Rémi Denis-Courmont remi at remlab.net
Fri Mar 27 09:52:13 CET 2020


Le perjantaina 27. maaliskuuta 2020, 10.41.20 EET Alexandre Janniaux a écrit :
> Hi,
> 
> On Thu, Mar 26, 2020 at 11:38:32AM +0100, Romain Vimont wrote:
> > On 3/26/20 11:22 AM, Alexandre Janniaux wrote:
> > > SLresult is defined as an SLuint32 and might not be represented as an
> > > unsigned long int. It is raising warnings when compiling for android
> > > aarch64, so display it as uint32 instead.
> > 
> > If the fact that SLresult is a SLuint32 is an implementation detail, then
> > either it should expose some PRIslresult (I guess it does not), or IMO it
> > 
> > should be casted for the printf:
> >     printf("%lu", (unsigned long) result);
> > 
> > Otherwise, LGTM.
> 
> Actually, it's not an implementation detail as you can read
> that in the specifications p.59 in 5.2:

SLresult is always SLuint32, but SLuint32 is system-dependent.

-- 
Реми Дёни-Курмон
http://www.remlab.net/





More information about the vlc-devel mailing list