[vlc-devel] [PATCH] opensles_android: fix integer print format

Alexandre Janniaux ajanni at videolabs.io
Fri Mar 27 10:39:32 CET 2020


Hi,

To be exact, my question implied two questions:

+ as it should be stored on SLuint32, should casting to uint32_t
  without checking size/overflow be ok?
+ as SLuint32 is specified as a «32-bit unsigned type», and not
  «at least 32bit-signed type», shouldn't it be ok to assume that
  it's already the same type as uint32_t?

Regards,
--
Alexandre Janniaux
Videolabs

On Fri, Mar 27, 2020 at 10:19:16AM +0100, Alexandre Janniaux wrote:
> Hi,
>
> On Fri, Mar 27, 2020 at 11:10:13AM +0200, Rémi Denis-Courmont wrote:
> > Le perjantaina 27. maaliskuuta 2020, 11.03.06 EET Alexandre Janniaux a écrit :
> > > Hi,
> > >
> > > Isn't it what I wrote ?
> >
> > You wrote something rather ambiguous: while SLresult is guaranteed to be
> > SLuint32, Romain's point remains valid.
>
> I wrote:
>
> > However, the fact SLuint32 would be a uint32_t is an
> > implementation detail, do you think it should have a cast
> > to uint32_t ?
>
> Which litterally match what you said after, but your mail
> doesn't provide an answer to this, so I'm not sure what
> you're trying to bring here.
>
> Regards,
> --
> Alexandre Janniaux
> Videolabs
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list