[vlc-devel] [PATCH] opensles_android: fix integer print format

Alexandre Janniaux ajanni at videolabs.io
Fri Mar 27 11:08:18 CET 2020


Hi,

On Fri, Mar 27, 2020 at 11:52:48AM +0200, Rémi Denis-Courmont wrote:
> Le perjantaina 27. maaliskuuta 2020, 11.39.32 EET Alexandre Janniaux a écrit :
> > Hi,
> >
> > To be exact, my question implied two questions:
> >
> > + as it should be stored on SLuint32, should casting to uint32_t
> >   without checking size/overflow be ok?
>
> That should work.
>
> > + as SLuint32 is specified as a «32-bit unsigned type», and not
> >   «at least 32bit-signed type», shouldn't it be ok to assume that
> >   it's already the same type as uint32_t?
>
> How does that work on LPI32 or LLP64 platforms where you have two incompatible
> 32-bit interger types?

Thanks for this answer, very instructive ! :)

I'll fix the patch then,

Regards,
--
Alexandre Janniaux
Videolabs


More information about the vlc-devel mailing list