[vlc-devel] [PATCH] access_output: udp: fix conversion from uint8_t* to const char*

[Steve Lhomme]

On 2020-03-27 14:55, Rémi Denis-Courmont wrote:
> Le perjantaina 27. maaliskuuta 2020, 15.43.03 EET Alexandre Janniaux a écrit :
>> I guess the issue on windows is that send doesn't take
>> a `const void*`:
> 
> There are only two possible types for raw byte blob: void * and
> unsigned char *. 

three: 
https://docs.microsoft.com/en-us/windows/win32/api/winsock2/nf-winsock2-send

> The specifications typically require void * to avoid cast
> warnings, as is indeed the case for the socket API or more generally the Unix
> I/O functions. signed char * is however plain wrong.
> 
> In other words, the cast in patch is a useless no-op on ARM, and AFAICT wrong
> on x86. Thus -1.
> 
> -- 
> Реми Дёни-Курмон
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>