[vlc-devel] [PATCH] libmp4: fix argument for formatting

Alexandre Janniaux ajanni at videolabs.io
Fri Mar 27 16:45:16 CET 2020


i_profile_level is uint8_t but the bitwise operation is promoting it to
an int, leading to warnings (-Wformat) when compiling for darwin
platforms. There's no warning to report on Linux with both gcc and clang
though.
---
 modules/demux/mp4/libmp4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/demux/mp4/libmp4.c b/modules/demux/mp4/libmp4.c
index c9dacb9079..67fc38b2e3 100644
--- a/modules/demux/mp4/libmp4.c
+++ b/modules/demux/mp4/libmp4.c
@@ -2433,7 +2433,7 @@ static int MP4_ReadBox_dvc1( stream_t *p_stream, MP4_Box_t *p_box )
 
 #ifdef MP4_VERBOSE
     msg_Dbg( p_stream,
-             "read box: \"dvc1\" profile=%"PRIu8, (p_dvc1->i_profile_level & 0xf0) >> 4 );
+             "read box: \"dvc1\" profile=%"PRIu8, (uint8_t)((p_dvc1->i_profile_level & 0xf0) >> 4) );
 #endif
 
     MP4_READBOX_EXIT( 1 );
-- 
2.26.0



More information about the vlc-devel mailing list