[vlc-devel] [PATCH 2/2] npapi: pass the enable PDB flag to the NPAPI build

[Alexandre Janniaux]

Hi,

Maybe the variable can have a better name about what it
stores, like ENABLE_PDB_OPTION.

Otherwise LGTM too.

Regards,
--
Alexandre Janniaux
Videolabs

On Tue, Mar 31, 2020 at 10:19:33AM +0200, Steve Lhomme wrote:
> ---
>  extras/package/npapi.am | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/extras/package/npapi.am b/extras/package/npapi.am
> index 6bcbb783702..34e0aca34a3 100644
> --- a/extras/package/npapi.am
> +++ b/extras/package/npapi.am
> @@ -30,11 +30,16 @@ npapi-vlc/configure: stamp-npapi
>  	$(SHELL) ./autogen.sh
>  	touch $@
>
> +if ENABLE_PDB
> +FORWARD_ENABLE_PDB := --enable-pdb
> +endif
> +
>  npapi-vlc/Makefile: npapi-vlc/configure
>  	cd npapi-vlc && \
>  	$(SHELL) ./configure \
>  		--prefix=/ \
>  		--host=$(host_alias) --build=$(build_alias) \
> +		$(FORWARD_ENABLE_PDB) \
>  		CPP="$(CPP)" CPPFLAGS="$(CPPFLAGS)" \
>  		CC="$(CC)" CFLAGS="$(CFLAGS)" \
>  		CXX="$(CXX)" CXXFLAGS="$(CXXFLAGS)" \
> --
> 2.17.1
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel