[vlc-devel] [PATCH v2 13/17] contrib: use makefile instead of environment variable

Rémi Denis-Courmont remi at remlab.net
Fri May 1 18:43:01 CEST 2020

Le perjantaina 1. toukokuuta 2020, 17.17.10 EEST Marvin Scholz a écrit :
> On 1 May 2020, at 15:58, Alexandre Janniaux wrote:
> > I'll move the hook from contrib/bootstrap to the apple script,
> > if everyone agree.
> I am fine with the way you did it in this patch.

This patch is contrary to the very design of the contrib system which is meant 
to automatically adjust to the selected target, and not be tied to specific OS 
versions/variants liek the previous systems were.

Not only that, but as already pointed out in this thread, this incorrectly 
assumes that all contribs use the autoconf cache system, which is obviously 
not true. Though apparently some people here have reading disabilities since 
this was already mentioned and yet they claim otherwise.

This patch is wrong.


More information about the vlc-devel mailing list