[vlc-devel] [PATCH] macosx/configure: setup environment before configuring

[Alexandre Janniaux]

Hi,

I usually prefer an absolute value for SCRIPTDIR as it can
lead to failure and waste of time in case there is a `cd`
in the code at some step.

If you want to comply to the shebang, `source` should be
replaced by a dot too.

Other than that, LGTM.

Regards,
--
Alexandre Janniaux
Videolabs

On Thu, Apr 30, 2020 at 02:33:18PM +0200, Felix Paul Kühne wrote:
> From: Felix Paul Kühne <felix at feepk.net>
>
> ---
>  extras/package/macosx/configure.sh | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/extras/package/macosx/configure.sh b/extras/package/macosx/configure.sh
> index 5bd06de79c..e9ec3c9bb6 100755
> --- a/extras/package/macosx/configure.sh
> +++ b/extras/package/macosx/configure.sh
> @@ -1,5 +1,8 @@
>  #!/bin/sh
>
> +SCRIPTDIR=$(dirname "$0")
> +source "$SCRIPTDIR/env.build.sh" "none"
> +
>  CFLAGS=${CFLAGS}
>  LDFLAGS=${LDFLAGS}
>
> @@ -39,4 +42,6 @@ OPTIONS="
>  export CFLAGS
>  export LDFLAGS
>
> +vlcSetSymbolEnvironment
> +
>  sh "$(dirname $0)"/../../../configure ${OPTIONS} "$@"
> --
> 2.21.1 (Apple Git-122.3)
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel