[vlc-devel] [PATCH 04/25] cpu: add CPU feature masking

[Victorien Le Couviour]

Hi Thomas,

I was wrong when I said I don't need the core,
I still do (for pic creation when testing and benching vfilters, in this
case the deinterlacers).

I see what you mean, yeah I think that should work. Will try it.
Thanks for the idea.

Victorien.

On Tue, Apr 14, 2020 at 9:47 PM Thomas Guillem <thomas at gllm.fr> wrote:

>
>
> On Tue, Apr 14, 2020, at 18:45, Rémi Denis-Courmont wrote:
> > Le tiistaina 14. huhtikuuta 2020, 19.23.18 EEST Victorien Le Couviour a
> écrit
> > :
> > > On Tue, Apr 14, 2020 at 5:54 PM Rémi Denis-Courmont <remi at remlab.net>
> wrote:
> > > > Le tiistaina 14. huhtikuuta 2020, 18.42.56 EEST Victorien Le
> Couviour a
> > > > écrit
> > > >
> > > > > Hi,
> > > > >
> > > > > Doesn't that imply I'd have to write a version per feature I want
> to
> > > >
> > > > test?
> > > >
> > > > No but it does imply that you don't kludge the LibVLC run-time to
> suit
> > > > your specific test. Like everybody else who's ever written a test
> case
> > > > here.
> > >
> > > I don't see how this can work.
> >
> > So you can patch the Makefile to include select C file in your benchmark
> tool,
> > but you cannot (think to) patch it to have different CFLAGS and a
> different
> > vlc_CPU() implementation?
> >
> > That's what I call taking reviewers for fools, and it really pisses me
> off.
>
> I found that asking advices to reviewers is very sane personally. I really
> don't see how Victorien patch set or comments can piss off someone else.
>
>
> Victorien, what about a common header file in modules that #undef /
> #define the requesting vlc_CPU. This header could be used by all your tests.
>
> >
> > --
> > Rémi Denis-Courmont
> > Tapiola new town, Uusimaan Republic
> >
> >
> >
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200501/e16713a7/attachment.html>