[vlc-devel] [PATCH v2 13/17] contrib: use makefile instead of environment variable

[Rémi Denis-Courmont]

Le perjantaina 1. toukokuuta 2020, 22.23.54 EEST Marvin Scholz a écrit :
> On 1 May 2020, at 21:19, Rémi Denis-Courmont wrote:
> > Le perjantaina 1. toukokuuta 2020, 21.13.14 EEST Marvin Scholz a écrit :
> >> The whole purpose of these hacks, as I already explained, is to
> >> workaround the incorrect way autoconf does the checks. So of course it is
> >> specific to autoconf.
> > 
> > There is nothing incorrect about autoconf *there* and nothing specific to
> > autoconf either. If you ask autoconf to check for a symbol, it does so.
> > The
> > same is true of cmake or of bespoke configure scripts.
> 
> Yes there is, I already explained it, I won't repeat myself over and over
> again just because you refuse to read and understand what I write…

What mail do I refuse to read?

> > Sometimes, checking for symbols is wrong because a function or functional
> > macro is not guaranteed to exists under the same name as a symbol. In that
> > case, a proper code snippet compilation test is necessary. But failing
> > that can only ever lead to false negatives, not false positives.
> 
> No, you are wrong there.

No, you are.

> > What's incorrect is the way you're building packages with automatic
> > configuration (using autotools or otherwise). You are literaly not
> > building
> > those the way they're supposed to be built.
> 
> No, your assumptions how things should be done are wrong, when compiling
> with macOS / iOS SDKs and doing specific version targeting.

No those are not my assumptions and I already explained it.

Patch rejected.

-- 
Реми Дёни-Курмон
http://www.remlab.net/