[vlc-devel] [PATCH v2 13/17] contrib: use makefile instead of environment variable

[Rémi Denis-Courmont]

	Hi,

Le torstaina 30. huhtikuuta 2020, 13.18.14 EEST Martin Storsjö a écrit :
> > I think ePirat spent a lot of time on this issue and even
> > had apple engineer telling him that it cannot be supported
> > that way by autotools, so it's probably harder to integrate.
> 
> Hmm, ok, maybe there are pitfalls with trying to force it upon autotools
> in general. -Werror=partial-availability has been introduced and used
> successfully within both ffmpeg and curl at least, for avoiding exactly
> this issue of detecting things that are present but shouldn't be used yet.

Do you mean that FFmpeg sticks to compilation tests and never does link tests? 
That's arguably ideal, but I don't think it's viable for the entirety of the 
120-some VLC contrib packages.

I can see the benefit of partial availability for proprietary or BSD-style OSS 
code, especially macOS-only programs. But the (L)GPL would require that VLC 
built natively for a given OS version can build on that OS (SDK) version. So 
for (L)GPL code as FFmpeg or VLC, that command line flag seems more like a 
copyright foot gun than something that should be promoted.

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/