[vlc-devel] [PATCH] keystore: makefile: link cocoa only on OSX

[Marvin Scholz]

LGTM

On 4 May 2020, at 10:34, Alexandre Janniaux wrote:

> Cocoa doesn't exist on iOS and tvOS.
> ---
>  modules/keystore/Makefile.am | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/modules/keystore/Makefile.am 
> b/modules/keystore/Makefile.am
> index 9d5e5bcc780..57ae2273f60 100644
> --- a/modules/keystore/Makefile.am
> +++ b/modules/keystore/Makefile.am
> @@ -28,7 +28,11 @@ libkwallet_plugin_la_LIBADD = $(DBUS_LIBS) $(LIBM)
>
>  libkeychain_plugin_la_SOURCES = keystore/keychain.m 
> keystore/list_util.c keystore/list_util.h
>  libkeychain_plugin_la_OBJCFLAGS = $(AM_OBJCFLAGS) -fobjc-arc
> -libkeychain_plugin_la_LDFLAGS = $(AM_LDFLAGS) -rpath '$(keystoredir)' 
> -Wl,-framework,Foundation -Wl,-framework,Security -Wl,-framework,Cocoa
> +libkeychain_plugin_la_LDFLAGS = $(AM_LDFLAGS) -rpath '$(keystoredir)' 
> -Wl,-framework,Foundation -Wl,-framework,Security
> +
> +if HAVE_OSX
> +libkeychain_plugin_la_LDFLAGS += -Wl,-framework,Cocoa
> +endif
>
>  if HAVE_DARWIN
>  keystore_LTLIBRARIES += libkeychain_plugin.la
> -- 
> 2.26.2
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel