[vlc-devel] [PATCH 1/2] video_output: Makefile.am: fix link for interop_cvpx on ios

[Alexandre Janniaux]

Hi,

> I am surprised that you can remove IOSurface and Foundation on macOS

The diff is a bit confusing, especially given than
-Wl,-framework,IOSurface is padded in a new line in the answer,
but I add Foundation and CoreVideo for every platform in first
part of the diff, and in addition I add IOSurface and OpenGL
for macosx.

Previously it was only defined for MacOSX (where I removed it
in the diff).

I haven't tested if some can be removed as I mainly focus on
having the dynamic linking working on iOS, but anyway the
IOSurface framework is a iOS 11.0+ framework and there is no
public usage in the module for iOS, although there is for
MacOSX.

Regards,
--
Alexandre Janniaux
Videolabs

On Mon, May 04, 2020 at 11:49:18AM +0200, Jean-Baptiste Kempf wrote:
>
>
> On Mon, May 4, 2020, at 11:44, Alexandre Janniaux wrote:
> > There were no LDFLAGS for iOS/tvOS and vt_utils were not compiled but
> > linking worked because videotoolbox was linked in the final static
> > library archive.
> > ---
> >  modules/video_output/Makefile.am | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/modules/video_output/Makefile.am b/modules/video_output/Makefile.am
> > index c82e9a0ed71..4fd34f2737d 100644
> > --- a/modules/video_output/Makefile.am
> > +++ b/modules/video_output/Makefile.am
> > @@ -41,7 +41,9 @@ endif
> >
> >  libglinterop_cvpx_plugin_la_SOURCES = video_output/opengl/interop_cvpx.c \
> >  	video_output/opengl/interop.h
> > -libglinterop_cvpx_plugin_la_LDFLAGS = $(AM_LDFLAGS) -rpath '$(voutdir)'
> > +libglinterop_cvpx_plugin_la_SOURCES += codec/vt_utils.c codec/vt_utils.h
> > +libglinterop_cvpx_plugin_la_LDFLAGS = $(AM_LDFLAGS) -rpath '$(voutdir)' \
> > +	-Wl,-framework,Foundation,-framework,CoreVideo
> >
> >  if HAVE_OSX
> >  libvout_macosx_plugin_la_SOURCES = video_output/macosx.m
> > $(OPENGL_COMMONSOURCES)
> > @@ -56,9 +58,7 @@ libcaopengllayer_plugin_la_LIBADD =
> > $(OPENGL_COMMONLIBS)
> >  libcaopengllayer_plugin_la_LDFLAGS = $(AM_LDFLAGS) -rpath '$(voutdir)'
> > \
> >  	-Wl,-framework,OpenGL,-framework,Cocoa,-framework,QuartzCore
> >
> > -libglinterop_cvpx_plugin_la_SOURCES += codec/vt_utils.c
> > codec/vt_utils.h
> > -libglinterop_cvpx_plugin_la_LDFLAGS += -Wl,-framework,IOSurface \
> > -	-Wl,-framework,Foundation,-framework,CoreVideo,-framework,OpenGL
> > +libglinterop_cvpx_plugin_la_LDFLAGS +=
> > -Wl,-framework,IOSurface,-framework,OpenGL
> >  vout_LTLIBRARIES += libvout_macosx_plugin.la
>
> --
> Jean-Baptiste Kempf -  President
> +33 672 704 734
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel