[vlc-devel] [PATCH 2/2] video_output: Makefile.am: link vout_ios to Foundation

[Alexandre Janniaux]

Actually, we are using CAEAGLLayer which is QuartzCore.

Regards.
--
Alexandre Janniaux
Videolabs

On Mon, May 04, 2020 at 12:18:30PM +0200, Jean-Baptiste Kempf wrote:
> OK, still I think anything Quartz should go.
>
> On Mon, May 4, 2020, at 12:17, Alexandre Janniaux wrote:
> > Hi,
> >
> > I don't know, it was already there, but given that I plan to
> > remove the module altogether I don't think this is an issue.
> >
> > I try to have dynamic plugins for iOS so as to build
> > a developement oriented iOS application in automake,
> > in particular to test my new vout that replaces this one.
> >
> > Regards,
> > --
> > Alexandre Janniaux
> > Videolabs
> >
> > On Mon, May 04, 2020 at 11:49:40AM +0200, Jean-Baptiste Kempf wrote:
> > > Yes, but do you really need QuartzCore here?
> > >
> > > On Mon, May 4, 2020, at 11:44, Alexandre Janniaux wrote:
> > > > Fixes the following undefined references:
> > > >
> > > >   "_OBJC_CLASS_$_NSNotificationCenter", referenced from:
> > > >       objc-class-ref in ios.o
> > > >   "_OBJC_CLASS_$_NSThread", referenced from:
> > > >       objc-class-ref in ios.o
> > > >   "_OBJC_CLASS_$_NSValue", referenced from:
> > > >       objc-class-ref in ios.o
> > > > ---
> > > >  modules/video_output/Makefile.am | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/modules/video_output/Makefile.am
> > > > b/modules/video_output/Makefile.am
> > > > index 4fd34f2737d..dd64a0680d6 100644
> > > > --- a/modules/video_output/Makefile.am
> > > > +++ b/modules/video_output/Makefile.am
> > > > @@ -70,7 +70,7 @@ libvout_ios_plugin_la_SOURCES = video_output/ios.m
> > > > $(OPENGL_COMMONSOURCES)
> > > >  libvout_ios_plugin_la_CFLAGS = $(AM_CFLAGS) $(OPENGL_COMMONCFLAGS)
> > > > -DUSE_OPENGL_ES2
> > > >  libvout_ios_plugin_la_LIBADD = $(OPENGL_COMMONLIBS)
> > > >  libvout_ios_plugin_la_LDFLAGS = $(AM_LDFLAGS) -rpath '$(voutdir)' \
> > > > -	-Wl,-framework,OpenGLES,-framework,QuartzCore,-framework,UIKit
> > > > +	-Wl,-framework,Foundation,-framework,OpenGLES,-framework,QuartzCore,-framework,UIKit
> > > >  if HAVE_IOS
> > > >  vout_LTLIBRARIES += libvout_ios_plugin.la libglinterop_cvpx_plugin.la
> > > >  endif
> > > > --
> > > > 2.26.2
> > > >
> > > > _______________________________________________
> > > > vlc-devel mailing list
> > > > To unsubscribe or modify your subscription options:
> > > > https://mailman.videolan.org/listinfo/vlc-devel
> > >
> > > --
> > > Jean-Baptiste Kempf -  President
> > > +33 672 704 734
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
>
> --
> Jean-Baptiste Kempf -  President
> +33 672 704 734
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel