[vlc-devel] [PATCH 1/2] dvdnav: Improve user information about insufficient permissions

[Marvin Scholz]

On 5 May 2020, at 10:35, Francois Cartegnie wrote:

> Le 04/05/2020 à 20:09, david.fuhrmann at gmail.com a écrit :
>> From: David Fuhrmann <dfuhrmann at videolan.org>
>>
>> The mentioned security setting is only relevant for accessing
>> RAW block devices (/dev/xxx), which is one of the main use cases
>> for this module (accessing an optical drive).
>> It is not relevant for file or folder access.
>>
>> Probe for this case explicitly to inform the user only there.
>>
>> This is only relevant starting with macOS Catalina.
>> ---
>>  modules/access/Makefile.am  |  2 +-
>>  modules/access/dvd_helper.h | 57 +++++++++++++++++++++++++++++++++++++
>>  modules/access/dvdnav.c     | 19 ++++++++-----
> I don't see the point of splitting that code if that's not used by any
> other access. Or that needs to be renamed to be non DVD specific.
>

Well it's used by both dvdread.c and dvdread.c

> -- 
> Francois Cartegnie
> VideoLAN - VLC Developer
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel