[vlc-devel] [PATCH] bin: add iosvlc.m for iOS development

[Alexandre Janniaux]

Hi,

On Wed, May 06, 2020 at 04:53:57PM +0300, Rémi Denis-Courmont wrote:
> Le keskiviikkona 6. toukokuuta 2020, 15.25.05 EEST Alexandre Janniaux a écrit
> :
> > Hi,
> >
> > On Wed, May 06, 2020 at 03:10:52PM +0300, Rémi Denis-Courmont wrote:
> > > Hi,
> > >
> > > That looks more like a bug to me. Why is there no stand-alone provider to
> > > begin with? That should be even more useful on mobile platforms, where
> > > full screen is most common, and embedded video is least useful.
> > >
> > > And on the other hand, you could make the same point for all platforms
> > > anyway... We can't test the embedded provider on Windows or Linux easily.
> > > I don't see why that would be a particular problem on iOS.
> > That's not the same, there is litteraly no point in having
> > a different module for iOS, whereas we maintain both embedded
> > and desktop usage for Linux or Windows.
>
> How is it not the same? Why should LibVLC apps be required to provide a window
> on some OSes and not others? And considering the code that is (not) in this
> patch, it looks a rather trivial problem to solve.

I revised what I mean in the mail after the on you answered.
It is solvable in a different patchset but I still don't see
the need for this patch given that I could support both in the
binary.

Also, as I said, I refactored the iOS display to get rid of
it so I'd like to not change the code if not needed. I'll
add this in the new window provider module if it doesn't
break application development.

> And the testing problem affects all platforms. If you want to write a new test
> tool, you're welcome to add one in the test directory.

Given that it does exactly the same as vlc.c, it felt like
the canonical location for such code.

This is not automatic testing.

Regards,
--
Alexandre Janniaux
Videolabs