[vlc-devel] [PATCH v2 3/3] add vulkan wayland platform

[Alexandre Janniaux]

Hi,

On Thu, May 07, 2020 at 09:52:08PM +0300, Rémi Denis-Courmont wrote:
> Le torstaina 7. toukokuuta 2020, 20.42.34 EEST Alexandre Janniaux a écrit :
> The shorcuts taken by surface.c are okay as long as there was at mosty one
> "vulkan" module per install. surface.c is not too big, so it's okay to
> replicate the code but e.g. you should not have the same name for config items
> of different backends.
>
> Also static strings are better defined as arrays than constant pointers (to an
> array), and you can't have macros in module name and description as it breaks
> gettext.
>
> It's a bit unfair that it hits the Wayland patch, but it's effectively the first
> time that a single build would have multiple backends.

Indeed, it's also very wrong for vlc_vk_PlatformExt.

It probably also makes sense to move the WSI glue
into its own capability since it does not depend upon
libplacebo and as it would avoid duplicating the same
options.

As this is a bit more complex, I'll probably resend
a patchset without this patch and fix it later.

Thank you!

Regards,
--
Alexandre Janniaux
Videolabs