[vlc-devel] [PATCH 2/2] vaapi: add support for DRM modifiers

[Rémi Denis-Courmont]

Le sunnuntaina 10. toukokuuta 2020, 17.56.36 EEST Lionel Landwerlin a écrit :
> DRM modifiers communicate a description of the data layout in the
> buffers exported/imported through various API.
> 
> On Intel HW this exports tiling information as well as potential
> compression.
> 
> v2: Make modifier usage conditional to the appropriate vaapi version
> ---
>  configure.ac                                |  9 ++
>  modules/hw/vaapi/vlc_vaapi.c                | 15 ++++
>  modules/hw/vaapi/vlc_vaapi.h                | 10 +++
>  modules/video_output/opengl/interop_vaapi.c | 91 +++++++++++++++++++--
>  4 files changed, 117 insertions(+), 8 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index cc682e94c3..6372eb1514 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2608,6 +2608,7 @@ AS_IF([test "${enable_libva}" = "yes" -a
> "${have_avcodec}" != "yes" ], [ ])
> 
>  have_vaapi="no"
> +have_vaapi_11="no"
>  have_vaapi_drm="no"
>  have_vaapi_x11="no"
>  have_vaapi_wl="no"
> @@ -2621,6 +2622,13 @@ AS_IF([test "${enable_libva}" != "no"], [
>        AC_MSG_WARN([${LIBVA_PKG_ERRORS}.])
>      ])
>    ])
> +  PKG_CHECK_MODULES([LIBVA_11], [libva >= 1.1], [
> +    have_vaapi_11="yes"
> +  ], [
> +    AS_IF([test "${enable_libva}"], [
> +      AC_MSG_WARN([${LIBVA_PKG_ERRORS}.])
> +    ])
> +  ])
>    PKG_CHECK_MODULES([LIBVA_DRM], [libva-drm], [
>      have_vaapi_drm="yes"
>    ], [
> @@ -2641,6 +2649,7 @@ AM_CONDITIONAL([HAVE_VAAPI], [test "${have_vaapi}" =
> "yes"]) AM_CONDITIONAL([HAVE_VAAPI_DRM], [test "${have_vaapi_drm}" =
> "yes"]) AM_CONDITIONAL([HAVE_VAAPI_X11], [test "${have_vaapi_x11}" =
> "yes"]) AM_CONDITIONAL([HAVE_VAAPI_WL], [test "${have_vaapi_wl}" = "yes"])
> +AC_DEFINE([HAVE_VAAPI_11], [test "${have_vaapi_11}" = "yes"], [Define if
> VAAPI 1.1 is available])

But why? There's already version numbers in va_version.h. Plus changing 
config.h forces everybody to recompile everything just for one plugin.

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/