[vlc-devel] [PATCH 2/3] Contribs: medialibrary: add a libtool failure fixing patch

κΉ€μ •μ„λ‹˜(JUSTIN) jeongseok.kim at sk.com
Mon May 11 10:12:54 CEST 2020


From: "J. Kim" <jeongseok.kim at sk.com>

Without libtool tag, it fails to build on MacOSX.
---
 ...le.am-add-tag-option-to-libtool-flag.patch | 33 +++++++++++++++++++
 contrib/src/medialibrary/rules.mak            |  1 +
 2 files changed, 34 insertions(+)
 create mode 100644 contrib/src/medialibrary/0001-Makefile.am-add-tag-option-to-libtool-flag.patch

diff --git a/contrib/src/medialibrary/0001-Makefile.am-add-tag-option-to-libtool-flag.patch b/contrib/src/medialibrary/0001-Makefile.am-add-tag-option-to-libtool-flag.patch
new file mode 100644
index 0000000000..a20aaafd49
--- /dev/null
+++ b/contrib/src/medialibrary/0001-Makefile.am-add-tag-option-to-libtool-flag.patch
@@ -0,0 +1,33 @@
+From 9795d5c7cac498a5bc286e8a7d7c636efa9b7e4e Mon Sep 17 00:00:00 2001
+From: "J. Kim" <jeongseok.kim at sk.com>
+Date: Mon, 11 May 2020 16:12:54 +0900
+Subject: [PATCH] Makefile.am: add tag option to libtool flag
+
+Otherwise, it fails to build on macos
+with libtool's complain.
+
+```
+libtool: compile: unable to infer tagged configuration
+libtool:   error: specify a tag with '--tag'
+make[2]: *** [src/filesystem/darwin/libmedialibrary_macos_la-DeviceLister.lo] Error 1
+make[1]: *** [all] Error 2
+```
+---
+ Makefile.am | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/Makefile.am b/Makefile.am
+index 2189d9e2..7aa0ec1f 100644
+--- a/Makefile.am
++++ b/Makefile.am
+@@ -1,5 +1,7 @@
+ ACLOCAL_AMFLAGS = -I m4
+ 
++AM_LIBTOOLFLAGS = --tag CC
++
+ AM_CXXFLAGS = -Wall -Wsign-compare -Wextra -Wstrict-aliasing -Wstrict-overflow \
+ 			  -Wformat=2 -Wno-unused-parameter -Wcast-align -Wpointer-arith \
+ 			  -Wwrite-strings \
+-- 
+2.26.0
+
diff --git a/contrib/src/medialibrary/rules.mak b/contrib/src/medialibrary/rules.mak
index 55642b35e6..41169fd2a1 100644
--- a/contrib/src/medialibrary/rules.mak
+++ b/contrib/src/medialibrary/rules.mak
@@ -20,6 +20,7 @@ medialibrary: medialibrary-$(MEDIALIBRARY_VERSION).tar.xz .sum-medialibrary
 	rm -rf $@-$(MEDIALIBRARY_VERSION) $@
 	mkdir -p $@-$(MEDIALIBRARY_VERSION)
 	tar xvf "$<" --strip-components=1 -C $@-$(MEDIALIBRARY_VERSION)
+	$(APPLY) $(SRC)/medialibrary/0001-Makefile.am-add-tag-option-to-libtool-flag.patch
 	$(call pkg_static, "medialibrary.pc.in")
 	$(UPDATE_AUTOCONFIG)
 	$(MOVE)
-- 
2.26.0


More information about the vlc-devel mailing list