[vlc-devel] [PATCH 00/12] Video integration within Qt interface for Windows

[Pierre Lamot]

On 2020-05-12 08:09, Steve Lhomme wrote:
> On 2020-05-11 21:50, Thomas Guillem wrote:
>> 
>> 
>> On Mon, May 11, 2020, at 19:11, Rémi Denis-Courmont wrote:
>>> Le maanantaina 11. toukokuuta 2020, 19.04.50 EEST Pierre Lamot a 
>>> écrit :
>>>> This branch allow integrating the video within the Qt interface on 
>>>> Windows
>>>> using DirectComposition
>>>> 
>>>> This should work on Windows 8+ (and fallback on a separate window 
>>>> for former
>>>> versions of windows)
>>> 
>>> Come on, that's never going to fly... Either Windows 7 installs are 
>>> pinned to
>>> 3.0 on the understanding that by the time 4.0 comes out, Windows 7 
>>> will be way
>>> out of support, or video embedding has to work on it.
>>> 
>>>> Note that this branch currently don't compile as-is on GCC CI as the 
>>>> MingW
>>>> headers (dcomp.h) provided in the docker are outdated. Should 
>>>> compile fine
>>>> on Clang CI though.
>>> 
>>> I don't see why this should get special wildcard to break builds, 
>>> TBH.
>> 
>> I don't see how it is breaking the build. The dev that will merge this 
>> patch set will have to update the debian docker file, or ask the CI 
>> maintainer to do it.
>> 
>> By the way, debian testing has dcomp.h.
> 
> He didn't say it's missing, he says it's outdated.
> 
> IMO the detection (of the missing features) should be added to
> configure.ac and disable the code accordingly.

that should be doable

> We could also provide
> the header in the contribs and remove it when we require building with
> a recent enough version of Mingw64 (we need to determine which version
> has a usable version and document it).
> 
> We already have a recent mingw64 full tree in the contribs. That can
> probably be reworked so we can extract the header from there.

Yes, the one from the contrib (mingw 7.0.0 downloaded by pthread) is 
recent enough, but not installed

> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel