[vlc-devel] [PATCH 2/7] win32: msi: use the detected way to run win32 exectuables

[Alexandre Janniaux]

Hi,

You can have sources of the tools without having them being
cross-platform, which is the case for wixtoolset:

http://lists.wixtoolset.org/pipermail/wix-devs-wixtoolset.org/2017-July/000840.html
https://github.com/wixtoolset/issues/issues/4381

Work has been done to have it run natively on linux but
it's not done by the main developers which don't care
about this.

Regards,
--
Alexandre Janniaux
Videolabs

On Tue, May 12, 2020 at 06:06:50PM +0300, Rémi Denis-Courmont wrote:
> Le tiistaina 12. toukokuuta 2020, 13.28.03 EEST Steve Lhomme a écrit :
> > ---
> >  extras/package/win32/msi.mak | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/extras/package/win32/msi.mak b/extras/package/win32/msi.mak
> > index 52c01636995b..ca818d140a5a 100644
> > --- a/extras/package/win32/msi.mak
> > +++ b/extras/package/win32/msi.mak
> > @@ -4,9 +4,9 @@ BUILT_SOURCES_distclean += \
> >  endif
> >
> >  WIXPATH=`wine winepath -u 'C:\\Program Files (x86)\\Windows Installer XML
> > v3.5\\bin'` -HEAT=wine "$(WIXPATH)/heat.exe"
> > -CANDLE=wine "$(WIXPATH)/candle.exe"
> > -LIGHT=wine "$(WIXPATH)/light.exe"
> > +HEAT=$(RUN_HOST_CMD) "$(WIXPATH)/heat.exe"
> > +CANDLE=$(RUN_HOST_CMD) "$(WIXPATH)/candle.exe"
> > +LIGHT=$(RUN_HOST_CMD) "$(WIXPATH)/light.exe"
> >  VLCDIR=`wine winepath -s \`wine winepath -w
> > '$(abs_top_builddir)/vlc-$(VERSION)'\``
> > MSIDIR=$(abs_srcdir)/extras/package/win32/msi
> >  W_MSIDIR=`wine winepath -w '$(MSIDIR)'`
>
> Why the hell do you even need to run native programs in the build system? If
> they're open-source, you can recompile them. In the worst cases, you can at
> least compile with libwine. And if they're proprietary, you can't use them for
> redistributable (GPL) builds.
>
> --
> Реми Дёни-Курмон
> http://www.remlab.net/
>
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel