[vlc-devel] [PATCH] contrib: gnutls: fix win32/winstore patches

Alexandre Janniaux ajanni at videolabs.io
Tue May 19 09:28:23 CEST 2020


The $(RECONF) issue has already been raised by Martin and
reverted indeed, but there are not much trace of what was
the issue. Can you provide more context on the errors?

I'd also like to have the RECONF since it errors on Archlinux
without it (or manual reconf).

About the patchset itself, does Microsoft provide an API for
crypto/secure transport like Apple does (or did now, it's
still confused to me) and that would be able to replace
gnutls, at least for VLC if not other contribs?

Alexandre Janniaux

On Tue, May 19, 2020 at 07:16:06AM +0200, Steve Lhomme wrote:
> On 2020-05-18 17:26, Rémi Denis-Courmont wrote:
> > Le maanantaina 18. toukokuuta 2020, 18.11.44 EEST Rémi Denis-Courmont a écrit
> > :
> > > Hi,
> > >
> > > I don't think it's appropriate to push such a huge patchset. It's pretty
> > > much impossible for anybody, except maybe you, to upgrade with this (or
> > > then it will break Windows).
> >
> > In other words, contribs is not the place to maintain large patchsets or
> > forks. Patches should be submitted upstream and backports should have the
> > cherry-pick cross-reference.
> I agree and I'm working on getting things pushed upstream. But there are
> many problems. Sometimes people just don't care or don't know their code
> enough or have unmaintained code (a month later I'm still waiting for a
> single answer for this patch
> https://gcc.gnu.org/pipermail/gcc-patches/2020-April/544191.html). Windows
> is less a priority for most projects and winstore builds even less. Plus
> it's a blurry/tricky subject noone really want to care about.
> That doesn't mean we don't want to support it and if we do, we have to do
> what it takes to get there, even if the original project doesn't. That's why
> we have so many patches in contribs, sometimes for dead projects. We still
> review our code, including patches to contribs.
> As for gnutls, it's a sensitive part that needs special care. I will submit
> what I can upstream, without much hope. But some of the patched code is not
> even in their repository. It's only in their packaged sources. It's probably
> comes from somewhere else but I don't know where yet.
> In any case, I won't push this one yet because it doesn't build in the CI:
> https://code.videolan.org/robUx4/vlc/-/jobs/395117
> I modify configure.ac but do *not* run RECONF because it fucks up the whole
> system (probably trying to handle that external code and failing). On my
> system, configure runs and when trying to build, it realizes configure.ac
> has changed and do the reconf and it works. Unfortunately it doesn't seem to
> work in the Docker images...
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

More information about the vlc-devel mailing list