[vlc-devel] [PATCH] contrib: set BUILD_SHARED_LIBS OFF (static libraries) for all cmake targets

[Alexandre Janniaux]

Hi,

You probably misread this hunk:

    diff --git a/contrib/src/main.mak b/contrib/src/main.mak
    index c48204608872..eadd02a80383 100644
    --- a/contrib/src/main.mak
    +++ b/contrib/src/main.mak
    @@ -396,7 +396,8 @@ endif
     RECONF = mkdir -p -- $(PREFIX)/share/aclocal && \
 	    cd $< && $(AUTORECONF) -fiv $(ACLOCAL_AMFLAGS)
     CMAKE = cmake . -DCMAKE_TOOLCHAIN_FILE=$(abspath toolchain.cmake) \
    -		-DCMAKE_INSTALL_PREFIX=$(PREFIX) $(CMAKE_GENERATOR)
    +		-DCMAKE_INSTALL_PREFIX=$(PREFIX) $(CMAKE_GENERATOR) \
    +		-DBUILD_SHARED_LIBS:BOOL=OFF

I don't have strong opinion on this.

Regards,
--
Alexandre Janniaux
Videolabs

On Wed, May 20, 2020 at 06:51:37PM +0300, Rémi Denis-Courmont wrote:
> Le keskiviikkona 20. toukokuuta 2020, 16.46.30 EEST Steve Lhomme a écrit :
> > We build all contribs as static libraries.
> >
> > The setting exists since CMake 3.0. For targets built with older CMake
> > settings the value is discarded.
>
> The patch seems to (only) remove stuff. I can't relate with the head line ??
>
> --
> Реми Дёни-Курмон
> http://www.remlab.net/
>
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel