[vlc-devel] [PATCH 1/3] lua: equalizer: use locale.h only if uselocale is available

Alexandre Janniaux ajanni at videolabs.io
Wed May 20 20:23:03 CEST 2020


It's actually an issue on Android. I mentioned it last time
while adding -landroid_support in configure.ac. My last
patch (not sent yet) isn't optimal nor mergeable probably
but it correctly use vlc_fixup for locale instead of linking
Android stub, which is far better.

Regards,
--
Alexandre Janniaux
Videolabs

On Wed, May 20, 2020 at 07:26:47PM +0300, Rémi Denis-Courmont wrote:
> Le keskiviikkona 20. toukokuuta 2020, 19.15.43 EEST Alexandre Janniaux a écrit
> :
> > Hi,
> >
> > What and why do you call it a non-issue? I'm not sure if
> > you're highlighting an issue with the patchset or not.
>
> Including an unnecessary header file is a non-issue. There are hundreds of
> occurences in the VLC code base.
>
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
>
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list