[vlc-devel] [PATCH 5/6] qt: constructing QFlags from int is deprecated since Qt 5.15

Pierre Lamot pierre at videolabs.io
Thu May 28 14:41:56 CEST 2020


  Zero initializing can be done with default constructor. here the default
  value of the parameter.
---
 modules/gui/qt/dialogs/mediainfo/info_panels.cpp           | 4 ++--
 modules/gui/qt/dialogs/preferences/preferences_widgets.cpp | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/modules/gui/qt/dialogs/mediainfo/info_panels.cpp b/modules/gui/qt/dialogs/mediainfo/info_panels.cpp
index 662c8dd45d..5650b772f4 100644
--- a/modules/gui/qt/dialogs/mediainfo/info_panels.cpp
+++ b/modules/gui/qt/dialogs/mediainfo/info_panels.cpp
@@ -548,7 +548,7 @@ InputStatsPanel::InputStatsPanel( QWidget *parent ): QWidget( parent )
      QLabel *topLabel = new QLabel( qtr( "Current"
                  " media / stream " "statistics") );
      topLabel->setWordWrap( true );
-     layout->addWidget( topLabel, 0, 0 );
+     layout->addWidget( topLabel, 0 );
 
      StatsTree = new QTreeWidget(this);
      StatsTree->setColumnCount( 3 );
@@ -611,7 +611,7 @@ InputStatsPanel::InputStatsPanel( QWidget *parent ): QWidget( parent )
     StatsTree->resizeColumnToContents( 0 );
     StatsTree->setColumnWidth( 1 , 200 );
 
-    layout->addWidget(StatsTree, 4, 0 );
+    layout->addWidget(StatsTree, 4 );
 
     statsView = new VLCStatsView( this );
     statsView->setFrameStyle( QFrame::NoFrame );
diff --git a/modules/gui/qt/dialogs/preferences/preferences_widgets.cpp b/modules/gui/qt/dialogs/preferences/preferences_widgets.cpp
index b1649ac6fa..bce11569da 100644
--- a/modules/gui/qt/dialogs/preferences/preferences_widgets.cpp
+++ b/modules/gui/qt/dialogs/preferences/preferences_widgets.cpp
@@ -270,7 +270,7 @@ void FileConfigControl::fillGrid( QGridLayout *l, int line )
     textAndButton->setMargin( 0 );
     textAndButton->addWidget( text, 2 );
     textAndButton->addWidget( browse, 0 );
-    l->addLayout( textAndButton, line, LAST_COLUMN, 0 );
+    l->addLayout( textAndButton, line, LAST_COLUMN );
 }
 
 FileConfigControl::FileConfigControl( vlc_object_t *_p_this,
@@ -514,7 +514,7 @@ ModuleConfigControl::ModuleConfigControl( vlc_object_t *_p_this,
 void ModuleConfigControl::fillGrid( QGridLayout *l, int line )
 {
     l->addWidget( label, line, 0 );
-    l->addWidget( combo, line, LAST_COLUMN, 0 );
+    l->addWidget( combo, line, LAST_COLUMN );
 }
 
 ModuleConfigControl::ModuleConfigControl( vlc_object_t *_p_this,
@@ -933,7 +933,7 @@ BoolConfigControl::BoolConfigControl( vlc_object_t *_p_this,
 
 void BoolConfigControl::fillGrid( QGridLayout *l, int line )
 {
-    l->addWidget( checkbox, line, 0, 1, -1, 0 );
+    l->addWidget( checkbox, line, 0, 1, -1 );
 }
 
 BoolConfigControl::BoolConfigControl( vlc_object_t *_p_this,
-- 
2.25.1



More information about the vlc-devel mailing list