[vlc-devel] [PATCH] medialibrary: thumbnailer: include stdexcept for runtime_error

Steve Lhomme robux4 at ycbcr.xyz
Fri May 29 16:45:51 CEST 2020


LGTM

On 2020-05-20 20:27, Alexandre Janniaux wrote:
> std::runtime_error is used in the code and stdexcept available through
> transitive inclusion from medialibrary headers, but it might not be and
> it is much safer to include it ourselves.
> ---
>   modules/misc/medialibrary/Thumbnailer.cpp | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/modules/misc/medialibrary/Thumbnailer.cpp b/modules/misc/medialibrary/Thumbnailer.cpp
> index 0a5aafe7f0e..51889e814e4 100644
> --- a/modules/misc/medialibrary/Thumbnailer.cpp
> +++ b/modules/misc/medialibrary/Thumbnailer.cpp
> @@ -30,6 +30,8 @@
>   #include <vlc_url.h>
>   #include <vlc_cxx_helpers.hpp>
>   
> +#include <stdexcept>
> +
>   Thumbnailer::Thumbnailer( vlc_medialibrary_module_t* ml )
>       : m_ml( ml )
>       , m_currentContext( nullptr )
> -- 
> 2.26.2
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> 


More information about the vlc-devel mailing list